[LiveComponent] Prevent __component property to be serialized when called JSON.stringify()
#2537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Bug
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
|||||||||
Kocal
force-pushed
the
fix-live-component-proxy-attr
branch
from
733c5ae to
05dc157
Compare
jwage
approved these changes
Jan 31, 2025
carsonbot
added
Status: Reviewed
smnandre
approved these changes
Jan 31, 2025
…called `JSON.stringify()`
Kocal
force-pushed
the
fix-live-component-proxy-attr
branch
from
05dc157 to
e04f8f0
Compare
|
(Added missing changelog) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following https://symfony-devs.slack.com/archives/C01FN4EQNLX/p1738238525455439
With some RUM tools that listen user interactions, some of them can
JSON.stringify()their payload. But if their payload contains an HTML element with the property__component(which represents aProxyto theLiveComponentinstance), then it tries to be serialized and lead to an error by trying to call an actiontoJSONand trigger an XHR request to/toJSON:Let's change the property assignment with
Object.defineProperty(), so the property is not enumarable and so not serialized whenJSON.stringify()is called:cc @jwage